nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 419351
Commit: d84f805e7952d4a0bc64b142b12343016486d967

x86_64-linux

Re: review dismiss in #419351 (comment)

No, this is not how this works.

 @@ pkgs/by-name/mi/microsoft-edge/package.nix: in
  
- stdenvNoCC.mkDerivation (finalAttrs: {
+ stdenv.mkDerivation (finalAttrs: {
    pname = "microsoft-edge";
--  version = "137.0.3296.83";
+-  version = "137.0.3296.68";
 +  version = "137.0.3296.93";
  
    src = fetchurl {
      url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_${finalAttrs.version}-1_amd64.deb";
--    hash = "sha256-wbiijvxzyyM9lxoMtcQHFqZYChlsHh0hNQTwdgxPpZY=";
+-    hash = "sha256-dgmQF6zpd8dAYKoTSiidk8VU6dZ/ZWEDlYD91IPaDEE=";
 +    hash = "sha256-SC8h6UQ/ee5ZlQWAZsmC1Co5Ky4kaXuoMpvVZtTIMHQ=";
    };

This cherry-pick did not apply cleanly, when it could have, because this is not a bump from 137.0.3296.83 to 137.0.3296.93 as the PR title and commit message suggest. It is a bump from 137.0.3296.68. This is why the CI check was failing. Rightfully so. You should not have dismissed it.

To quote the dismissed cherry-pick review:

Occasionally, it is not possible to cherry-pick exactly the same patch. This most frequently happens when resolving merge conflicts while cherry-picking or when updating minor versions of packages which have already advanced to the next major on unstable.

#417925 should have been backported first. This is why there was a merge-conflict to begin with.

Note that this would not have required multiple PRs. Cherry-picking multiple PRs in a single PR is perfectly fine, as long as it is communicated properly.

Sorry! I'm very new to this, I tried my best. 😅
I'll remember for the next time.